Remove linuxbrew automatic git repo migration #21200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON API provides an easy alternative for any users who still haven't migrated.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the automatic git repository migration from linuxbrew-core to homebrew-core. With the JSON API now providing an easy alternative for users who haven't migrated, the automatic migration code is no longer necessary. Users still using linuxbrew-core should either use the JSON API (by ensuring HOMEBREW_NO_INSTALL_FROM_API is not set) or manually update their repository remote.
Key changes:
- Removed automatic migration detection and execution logic
- Updated diagnostic message to guide users toward manual migration or JSON API usage
- Cleaned up environment variable documentation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/extend/os/linux/diagnostic.rb | Updated error message to direct users to either unset HOMEBREW_NO_INSTALL_FROM_API or manually update the repository remote |
| Library/Homebrew/cmd/update.sh | Removed migration logic that was triggered by HOMEBREW_LINUXBREW_CORE_MIGRATION and updated environment variable documentation |
| Library/Homebrew/cmd/update-report.rb | Removed code that automatically re-ran brew update for linuxbrew-core migration |
| Library/Homebrew/brew.sh | Removed detection code that set HOMEBREW_LINUXBREW_CORE_MIGRATION when a linuxbrew-core repository was detected |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?The JSON API provides an easy alternative for any users who still haven't migrated.
This removes remaining Linuxbrew migration handling (other than diagnostic message) following: