os/mac/xcode: remove obsolete PKGID #21199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on da56a45, the PKGID was changed in Mavericks and then reverted in Yosemite.
2c455cc to
c0125f8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes obsolete Command Line Tools package ID support that was only used briefly during macOS Mavericks. Based on historical changes, the MAVERICKS_NEW_PKG_ID (com.apple.pkg.CLTools_Base) was introduced in Mavericks but then reverted in Yosemite, making it no longer relevant for any supported macOS versions.
- Removes the obsolete
MAVERICKS_NEW_PKG_IDconstant - Simplifies the
detect_versionmethod by removing unnecessary iteration - Maintains equivalent functionality for all currently supported macOS versions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Based on da56a45, the PKGID was changed in Mavericks and then reverted in Yosemite.