-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
Move to ubuntu-slim #21196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to ubuntu-slim #21196
Conversation
e97bede to
6e72411
Compare
|
Blocked on Homebrew/actions#770 |
6e72411 to
f76700f
Compare
|
ubuntu-slim is a container so not sure if container-in-container will be supported. Maybe just try everything without |
bc13628 to
60c9eba
Compare
Let's try to see if these workers are faster and/or cheaper and still work.
60c9eba to
b30a5c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request systematically replaces the ubuntu-latest runner with ubuntu-slim across 14 GitHub Actions workflow files in an experimental attempt to evaluate whether slim runners provide better performance or cost efficiency while maintaining functionality.
Key Changes
- Replaced
ubuntu-latestwithubuntu-slimrunner type across all applicable workflow jobs - Changes are consistent and uniform across all modified files
- No functional changes to workflow logic, only infrastructure changes
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/tests.yml |
Updated syntax, vendored-gems, update-test (Linux), and analytics (Linux) jobs to use ubuntu-slim |
.github/workflows/sync-default-branches.yml |
Updated sync job to use ubuntu-slim |
.github/workflows/stale-issues.yml |
Updated both mark-stale and label-pr jobs to use ubuntu-slim |
.github/workflows/sponsors-maintainers-man-completions.yml |
Updated updates and issue jobs to use ubuntu-slim |
.github/workflows/spdx.yml |
Updated spdx and issue jobs to use ubuntu-slim |
.github/workflows/sorbet.yml |
Updated issue job to use ubuntu-slim |
.github/workflows/sbom.yml |
Updated sbom and issue jobs to use ubuntu-slim |
.github/workflows/doctor.yml |
Updated determine-runners job to use ubuntu-slim |
.github/workflows/docs.yml |
Updated docs, deploy, and issue jobs to use ubuntu-slim |
.github/workflows/copilot-setup-steps.yml |
Updated copilot-setup-steps job to use ubuntu-slim |
.github/workflows/command-not-found-db-update.yml |
Updated delete-old-versions job to use ubuntu-slim |
.github/workflows/codeql-analysis.yml |
Updated analyze job to use ubuntu-slim |
.github/workflows/autogenerated-files.yml |
Updated autogenerated job to use ubuntu-slim |
.github/workflows/actionlint.yml |
Updated upload_sarif job to use ubuntu-slim |
Critical Issue Identified: The ubuntu-slim runner type is not a standard GitHub Actions hosted runner as of January 2025. All instances of this runner type should be verified to ensure it is either a newly introduced GitHub feature, a valid self-hosted runner label for this organization, or corrected if it's a typo. The workflows will fail if this runner type is not available.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Let's try to see if these workers are faster and/or cheaper and still work.