dev-cmd/test-bot: remove unused --concurrent-downloads
#21172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated --concurrent-downloads flag from the test-bot command, which has been a no-op since concurrent downloads were enabled by default. The removal is clean and complete.
Key Changes
- Removed the
--concurrent-downloadsswitch definition from the test-bot command - Auto-regenerated RBI type signature file to remove the corresponding method signature
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Library/Homebrew/dev-cmd/test-bot.rb |
Removed the hidden --concurrent-downloads switch and its TODO comment |
Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/test_bot_cmd.rbi |
Auto-generated update to remove the concurrent_downloads? method signature |
The changes look good! The PR correctly removes the unused flag from both the command definition and the auto-generated type signature file. I verified that:
- No other references to
concurrent_downloadsorconcurrent-downloadsexist in the codebase - The RBI file is properly auto-generated (as indicated by the header comment)
- No tests or documentation reference this flag
The removal is complete and appropriate.
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/test_bot_cmd.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?--concurrent-downloadsis currently a no-op as it is now enabled by default.