requirements/codesign_requirement: typed: strict and deprecate
#21170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR deprecates the CodesignRequirement class and upgrades it to typed: strict Sorbet mode. The class is no longer used in Homebrew (previously used by llvm and radare2 formulae but removed in 2019).
Key changes:
- Upgrades Sorbet typing from
typed: truetotyped: strict - Adds type signatures for all methods and instance variables
- Adds deprecation warning in the
satisfyblock
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9c77842 to
237af66
Compare
Deprecating CodesignRequirement as it is no longer used. The previous usage included: * llvm - Homebrew/homebrew-core#36278 * radare2 - Homebrew/homebrew-core#36289
237af66 to
0d25b32
Compare
p-linnane
approved these changes
Dec 3, 2025
MikeMcQuaid
approved these changes
Dec 4, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks, let's try the deprecation and we can always disable if anyone complains loudly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Deprecating CodesignRequirement as it is no longer used. The previous usage included:
Strict typing is part of
typed: strictin all (non-package) files in Homebrew organisation #17297