unversioned_cask_checker: typed: strict
#21166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates unversioned_cask_checker.rb to Sorbet's strict typing mode and refactors type filtering to use the Sorbet-recommended grep method instead of select with is_a? checks.
Key Changes:
- Upgraded Sorbet sigil from
typed: truetotyped: strict - Added
T.letannotations withT.nilabletypes to all lazily-initialized instance variables - Refactored type filtering from
.select { |a| a.is_a?(Type) }to.grep(Type)for better Sorbet flow-sensitivity
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Dec 3, 2025
Member
|
Thanks again again @cho-m! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Also switching to
Enumerable#grepbased on Sorbet recommendation:Part of
typed: strictin all (non-package) files in Homebrew organisation #17297