compilers: typed: strict
#21163
Merged
compilers: typed: strict
#21163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove some old code for GCC < 5
p-linnane
approved these changes
Dec 2, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the compilers module to use typed: strict Sorbet type checking and removes deprecated code for GCC versions earlier than 5.
- Adds comprehensive type signatures throughout
compilers.rbfor strict typing - Updates parameter type signatures for the
needsmethod fromT::Array[String]toSymbol(variadic syntax) - Refactors
determine_ccto use explicit case statement for clearer type handling - Removes obsolete version handling for GCC < 5 in the
gcc_majormethod
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/compilers.rb | Migrated to typed: strict with comprehensive type annotations, converted Compiler to T::Struct, and removed GCC < 5 handling |
| Library/Homebrew/software_spec.rb | Updated needs method signature to use variadic Symbol parameter type |
| Library/Homebrew/formula.rb | Updated needs method signature to match software_spec.rb |
| Library/Homebrew/extend/ENV/shared.rb | Refactored determine_cc with explicit case statement for better type safety |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Also remove some old code for GCC < 5
For:
typed: strictin all (non-package) files in Homebrew organisation #17297