outdated: respect HOMEBREW_UPGRADE_GREEDY_CASKS variable
#21138
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for the HOMEBREW_UPGRADE_GREEDY_CASKS environment variable to the brew outdated command, making its behavior consistent with the brew upgrade command. The environment variable allows users to specify a space-separated list of casks that should be treated as if the --greedy flag was passed when checking for outdated versions.
Key Changes:
- Introduced a new
upgrade_greedy_cask?method that checks if a cask should be treated as greedy based on either the--greedyflag or theHOMEBREW_UPGRADE_GREEDY_CASKSenvironment variable - Updated three call sites in the outdated command to use this new method instead of directly passing
args.greedy? - The implementation uses lazy initialization to parse the environment variable only once per command execution
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
22f61f5 to
b418b02
Compare
Closes #21132 Signed-off-by: botantony <antonsm21@gmail.com>
b418b02 to
8983a01
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks great, thanks @botantony!
brew lgtm(style, typechecking and tests) with your changes locally?Closes #21132