cmd/bundle: add --no-secrets switch. #21137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a --no-secrets switch to the brew bundle command that removes sensitive environment variables (matching /(cookie|key|token|password|passphrase)/i) before running exec, sh, or env subcommands. The PR also adds environment variable support for HOMEBREW_BUNDLE_CHECK and HOMEBREW_BUNDLE_NO_SECRETS, allowing these options to be set via environment variables instead of command-line flags.
Key changes:
- Added
--no-secretsswitch withHOMEBREW_BUNDLE_NO_SECRETSenvironment variable support - Added
HOMEBREW_BUNDLE_CHECKenvironment variable support to existing--checkswitch - Auto-generated Sorbet type signatures updated to include
no_secrets?method
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Library/Homebrew/cmd/bundle.rb | Added --no-secrets and --check switch definitions with environment variable mappings, and implementation to clear sensitive environment variables when executing commands |
| Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/bundle.rbi | Auto-generated Sorbet type signatures updated to include no_secrets? method and remove obsolete flatpak_remotes? methods |
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/bundle.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This is handy if you're creating a `brew bundle` environment that makes use of Homebrew's environment filtering of secrets/tokents/etc: `/(cookie|key|token|password|passphrase)/i` While we're here, let's also add `HOMEBREW_BUNDLE_CHECK` and `HOMEBREW_BUNDLE_NO_SECRETS` environment variables.
345c64e to
915d283
Compare
p-linnane
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is handy if you're creating a
brew bundleenvironment that makes use of Homebrew's environment filtering of secrets/tokents/etc:/(cookie|key|token|password|passphrase)/iWhile we're here, let's also add
HOMEBREW_BUNDLE_CHECKandHOMEBREW_BUNDLE_NO_SECRETSenvironment variables.