Update type signature for ==
#21135
Merged
Update type signature for ==
#21135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates type signatures for == methods across the codebase to use T.anything instead of T.untyped or more specific type annotations, following the official Sorbet documentation recommendations. The changes improve type safety while maintaining backward compatibility.
- Updated type signatures from
T.untypedor specific types toT.anythingfor equality comparison methods - Refactored implementations in
PyPI::PackageandBumpVersionParserto use case statements with explicit type handling - Ensured consistent pattern for equality methods across the codebase
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/version.rb | Updated == signature from T.untyped to T.anything |
| Library/Homebrew/utils/pypi.rb | Updated == signature to T.anything and refactored implementation to use case statement for safer type handling |
| Library/Homebrew/checksum.rb | Updated == signature from T.any(String, Checksum, Symbol) to T.anything (implementation already handles types correctly) |
| Library/Homebrew/bump_version_parser.rb | Updated == signature from T.untyped to T.anything and refactored implementation to use case statement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rylan12
approved these changes
Nov 27, 2025
Member
Rylan12
left a comment
There was a problem hiding this comment.
Nice! It's a shame rubocop-sorbet doesn't have a check for this tbh (or maybe it does, I haven't looked 🤷)
carlocab
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Updating a couple of these based on Sorbet docs: