test_bot: remove session-manager-plugin
#21127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to simplify the codebase by using the HOMEBREW_CASKROOM constant (defined in startup/config.rb) instead of requiring and using Cask::Caskroom.path. The change adds a cleanup operation to remove the session-manager-plugin cask during test bot cleanup on macOS.
Key Changes
- Adds cleanup of
session-manager-pluginfrom the caskroom during test bot cleanup before tests run on macOS - Leverages the existing
HOMEBREW_CASKROOMconstant to avoid an extra require statement
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
758b61c to
d279703
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
approved these changes
Nov 24, 2025
| delete_or_move bad_paths, sudo: true | ||
| elsif OS.mac? | ||
| delete_or_move HOMEBREW_CELLAR.glob("*") | ||
| delete_or_move HOMEBREW_CASKROOM.glob("session-manager-plugin") |
Member
There was a problem hiding this comment.
Suggested change
| delete_or_move HOMEBREW_CASKROOM.glob("session-manager-plugin") | |
| delete_or_move HOMEBREW_CASKROOM.glob("*") |
we should consider this as a future iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Seeing if possible to remove deprecated cask via test-bot to unblock CI. May need to also either discuss deprecation with GitHub side, and/or see if it can be migrated elsewhere.
There is an issue for aws tap to provide their own
session-manager-pluginand another issue in upstream to sign/notarize binary. Depending on license, could check if possible to make a Formula.Also trying to see if
HOMEBREW_CASKROOMfromstartup/config.rbworks rather than needing to useCask::Caskroom.path(which adds an extra require)