item: do not remove lib formulae/casks
#21126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where shell completions and brew formulae/brew casks commands were not suggesting formulae or casks with names starting with "lib". The issue occurred because the find command in items.sh was unconditionally pruning all directories named lib, which prevented discovery of formulae/casks in subdirectories like Formula/lib/ or Casks/lib/.
Key changes:
- Modified the find command to conditionally prune
libdirectories only when they are NOT insideFormulaorCasksdirectories - The fix preserves the exclusion of top-level
lib/directories while allowing traversal oflib/subdirectories within formula and cask directories
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
I noticed this problem with shell completions where it doesn't suggest anything that starts with `lib`. `brew formulae | grew '^lib'` doesn't show anything either. We should keep `lib/*` path if it is inside `Formula` or `Casks` directory Signed-off-by: botantony <antonsm21@gmail.com>
7100e83 to
91c2ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?I noticed this problem with shell completions where it doesn't suggest anything that starts with
lib.brew formulae | grew '^lib'doesn't show anything either. We should keeplib/*path if it is insideFormulaorCasksdirectory