system_config: typed: strict
#21124
Merged
system_config: typed: strict
#21124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #17297 Signed-off-by: botantony <antonsm21@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Sorbet type checking level from typed: true to typed: strict for system_config.rb and its OS-specific extensions. The change aims to improve type safety by adding explicit type signatures to all methods and declaring instance variables with T.let.
Key Changes:
- Changed type sigil from
typed: truetotyped: strictin all three files - Added type signatures (
sig) to previously untyped methods - Added
initializemethods to declare instance variables withT.let
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| Library/Homebrew/system_config.rb | Upgraded to strict typing; added signatures for clang, clang_build, describe_path, and config dump methods; added initialize method to declare instance variables |
| Library/Homebrew/extend/os/mac/system_config.rb | Upgraded to strict typing; added signatures for Mac-specific methods (xcode, clt, describe_clang) and config methods; added initialize method |
| Library/Homebrew/extend/os/linux/system_config.rb | Upgraded to strict typing; added signatures for Linux-specific methods (host_glibc_version, host_gcc_version, formula_linked_version, etc.) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: botantony <antonsm21@gmail.com>
MikeMcQuaid
reviewed
Nov 23, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Great work, thanks @botantony!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Related to #17297