shims/super/cc: use canonical_path on <sysroot>/usr/lib
#21122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
system_library_paths is used by refurbished_args to detect duplicate/unneeded `-L<path>` flags; however, the shim does comparisons to `canonical_path(<path>)`. This means an SDK path like `/Library/Developer/CommandLineTools/SDKs/MacOSX26.sdk` won't work as it is a symlink to MacOSX26.0.sdk This then can cause issues if build is run with `-L` to SDK path as it can cause the wrong libraries to be linked. This is often an issue elsewhere (e.g. seen in PHP) but this PR allows the shim to handle this case better.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where SDK symlinks (e.g., MacOSX26.sdk → MacOSX26.0.sdk) prevent the superenv shim from properly detecting and removing duplicate -L<path> flags during argument refurbishment. The fix applies canonical_path to resolve symlinks in the sysroot library path, ensuring consistent path comparisons.
- Applies
canonical_path()to"#{sysroot}/usr/lib"insystem_library_pathsmethod - Ensures SDK library paths are canonicalized for proper deduplication in
refurbished_args - Eliminates the need for workarounds in formula files that manually set
HOMEBREW_SDKROOTto the realpath
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ZhongRuoyu
approved these changes
Nov 21, 2025
botantony
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?system_library_paths is used by refurbished_args to detect duplicate/unneeded
-L<path>flags; however, the shim does comparisons tocanonical_path(<path>). This means an SDK path like/Library/Developer/CommandLineTools/SDKs/MacOSX26.sdkwon't work as it is a symlink to MacOSX26.0.sdkThe old behavior can cause issues if build is run with
-Lto SDK path as it can find wrong libraries to be linked. The usage of SDK path is often an issue elsewhere (e.g. seen in PHP formula) but this PR allows the shim to handle particular scenario better.The alternative is workarounds like https://github.com/Homebrew/homebrew-core/blob/a41bd1a9053482dcdce96ab83b7f3e81f03d6ec3/Formula/p/php%408.4.rb#L133-L135