cask-cookbook: clarify desktop and launcher suffix in tokens
#21119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Cask Cookbook documentation to consolidate guidance on removing "Desktop" and "Launcher" suffixes from cask tokens. It merges previously separate guidelines into a single bullet point and adds an explicit exception for cases where these suffixes are intrinsic to the product name, using Docker Desktop as an example.
- Consolidated "Launcher" and "Desktop" suffix removal rules into a single bullet point
- Added an exception clause with Docker Desktop as the illustrative example
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
krehel
approved these changes
Nov 21, 2025
p-linnane
approved these changes
Nov 21, 2025
MikeMcQuaid
approved these changes
Nov 21, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Makes sense to me! Could even consider removing the whole line.
botantony
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?I don't believe there is any reason to require the omission of
-desktopor-launcherfrom a cask token when it is an intrinsic part of the product name, such asdocker-desktop. There has been room for some maintainer discretion here in the past, so I think loosening the specific guidelines makes sense to me.