shims: move rustc_wrapper from super to shared #21114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves the rustc_wrapper shim script from the super directory to the shared directory, since it's used by both the std and super build environments. This improves code organization by placing shared utilities in the appropriate location.
- Moved
rustc_wrapperscript fromLibrary/Homebrew/shims/super/toLibrary/Homebrew/shims/shared/ - Updated both
std.rbandsuper.rbto reference the new location
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/shims/shared/rustc_wrapper | New location for the rustc wrapper script that prepends HOMEBREW_RUSTFLAGS to rustc arguments |
| Library/Homebrew/extend/ENV/super.rb | Updated RUSTC_WRAPPER path from super/rustc_wrapper to shared/rustc_wrapper |
| Library/Homebrew/extend/ENV/std.rb | Updated RUSTC_WRAPPER path from super/rustc_wrapper to shared/rustc_wrapper |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Since we use this in both std and super, it makes more sense to be in shared.
I don't think we need it on PATH (i.e. no extra symlinks to other super dirs) as it is never directly run but instead executed via RUSTC_WRAPPER