cmd/which-formula: use simpler check for performance #21101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?brew list <name>outputs all files in Cellar and hits Ruby code making it slow to run in a bash script. Could possibly usebrew list --formula | grep <name>but that has more overhead than just a directory check while doing essentially the same check.For example, when checking
rubycommand (withrubyformula installed), this is a 10x difference (5s vs 0.5s):Before:
After: