workflows/tests: tweak behaviour. #21091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Run on `push` events so that parallel tests files are cached correctly and used to speedup the suites. - Set a conservative timeout for tests to avoid them running for hours sometimes.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the tests job to run on push events and adds a timeout to prevent excessively long test runs. The changes support better caching of parallel test files by ensuring cache is populated on main/master branch pushes.
- Removes the
if: github.event_name != 'push'condition from thetestsjob to enable tests on push events - Adds a 30-minute timeout to the
testsjob to prevent tests from running indefinitely
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
botantony
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pushevents so that parallel tests files are cached correctly and used to speedup the suites.