Add Nice option to service #21088

devnoname120 · 2025-11-16T01:47:42Z

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

Summary

This PR adds support for the nice option in Homebrew services, allowing users to set the scheduling priority (nice level) for services on both macOS and Linux.

This PR is a follow to #14936
It aims to fix half of #14931

Changes

Added nice method to Service class with validation (accepts integers from -20 to 19)
Added Nice support to to_plist method for macOS launchd plist generation
Added Nice support to to_systemd_unit method for Linux systemd unit generation
Added nice to to_hash and from_hash methods for API serialization
Added comprehensive tests covering:
- Valid nice values (including zero)
- Values outside valid range
- requires_root is set when negative nice values are specified (negative nice values require root privileges)
- Verification that nice appears in generated plist and systemd unit files
Updated documentation in Formula-Cookbook.md

Motivation

Previously, Homebrew services supported Apple plist daemons which had Nice support, but with the switch to their own syntax it became impossible to define a nice value. This PR restores that functionality and extends it to work with both macOS (launchd) and Linux (systemd) service managers.

The nice level ranges from -20 (highest priority) to 19 (lowest priority), and an error is raised if negative nice values are used but requires_root is missing.

- Add nice method to Service class with validation (-20 to 19) - Automatically set requires_root for negative nice values - Add Nice support to plist (macOS) and systemd unit (Linux) generation - Add nice to to_hash and from_hash for API serialization - Add comprehensive tests for nice functionality - Update documentation with nice option

Copilot

Pull Request Overview

This PR adds support for the nice option to Homebrew services, allowing users to control the scheduling priority of services on both macOS and Linux. The nice level ranges from -20 (highest priority) to 19 (lowest priority).

Key changes:

Added nice method with validation and automatic requires_root handling for negative values
Extended plist and systemd unit generation to include nice values
Added comprehensive test coverage for all nice-related functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
docs/Formula-Cookbook.md	Documented the new `nice` option in the service configuration table
Library/Homebrew/service.rb	Implemented the `nice` method with validation, added nice support to plist/systemd generation, and integrated it with API serialization
Library/Homebrew/test/service_spec.rb	Added comprehensive test coverage for nice value validation, requires_root behavior, and output generation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

docs/Formula-Cookbook.md

Library/Homebrew/service.rb

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Library/Homebrew/service.rb

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

MikeMcQuaid

Thanks, looks great so far, a few small tweaks!

Library/Homebrew/service.rb

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

docs/Formula-Cookbook.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Library/Homebrew/service.rb

Library/Homebrew/test/service_spec.rb

Library/Homebrew/service.rb

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Library/Homebrew/test/service_spec.rb

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

MikeMcQuaid

Thanks, great work here @devnoname120, you rock!

Copilot AI review requested due to automatic review settings November 16, 2025 01:47

Copilot started reviewing on behalf of devnoname120 November 16, 2025 01:48 View session

Copilot finished reviewing on behalf of devnoname120 November 16, 2025 01:49

Copilot AI reviewed Nov 16, 2025

View reviewed changes

docs/Formula-Cookbook.md Outdated Show resolved Hide resolved

devnoname120 added 2 commits November 16, 2025 02:53

Attempt to fix Rubocop error

74c0dea

Match documentation style better

24b755c

Copilot AI review requested due to automatic review settings November 16, 2025 01:56

Copilot started reviewing on behalf of devnoname120 November 16, 2025 01:57 View session

devnoname120 commented Nov 16, 2025

View reviewed changes

Library/Homebrew/service.rb Outdated Show resolved Hide resolved

Copilot finished reviewing on behalf of devnoname120 November 16, 2025 02:00

Copilot AI reviewed Nov 16, 2025

View reviewed changes

Library/Homebrew/service.rb Outdated Show resolved Hide resolved

Swap position of @nice and @require_root

5945712

devnoname120 requested a review from Copilot November 16, 2025 02:08

Copilot started reviewing on behalf of devnoname120 November 16, 2025 02:09 View session

Copilot finished reviewing on behalf of devnoname120 November 16, 2025 02:11

Copilot AI reviewed Nov 16, 2025

View reviewed changes

MikeMcQuaid reviewed Nov 16, 2025

View reviewed changes

Library/Homebrew/service.rb Outdated Show resolved Hide resolved

Library/Homebrew/service.rb Outdated Show resolved Hide resolved

devnoname120 added 3 commits November 16, 2025 23:30

Fix lint and reduce nesting

42be95e

Raise error if negative nice value without root

3a9a828

Fix linter error Modifier form line too long

69338c5

Copilot AI review requested due to automatic review settings November 16, 2025 22:37

Copilot started reviewing on behalf of devnoname120 November 16, 2025 22:37 View session

devnoname120 commented Nov 16, 2025

View reviewed changes

Library/Homebrew/service.rb Outdated Show resolved Hide resolved

Copilot finished reviewing on behalf of devnoname120 November 16, 2025 22:40

Copilot AI reviewed Nov 16, 2025

View reviewed changes

docs/Formula-Cookbook.md Outdated Show resolved Hide resolved

devnoname120 added 2 commits November 16, 2025 23:46

Helper func for neg nice root check to fix lint

03d69fa

Change nice_requires_root! to ?

783a80d

Copilot AI review requested due to automatic review settings November 16, 2025 22:51

Copilot started reviewing on behalf of devnoname120 November 16, 2025 22:51 View session

Add note about negative nice values in documentation

c0cf64b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot finished reviewing on behalf of devnoname120 November 16, 2025 22:55

Copilot AI reviewed Nov 16, 2025

View reviewed changes

Library/Homebrew/service.rb Outdated Show resolved Hide resolved

Library/Homebrew/test/service_spec.rb Outdated Show resolved Hide resolved

Library/Homebrew/test/service_spec.rb Outdated Show resolved Hide resolved

Make comparison explicit to fix nil return value

45a834a

devnoname120 commented Nov 16, 2025

View reviewed changes

Library/Homebrew/service.rb Show resolved Hide resolved

Narrow test raise expect to service parse

1800702

Copilot AI review requested due to automatic review settings November 16, 2025 23:06

Copilot started reviewing on behalf of devnoname120 November 16, 2025 23:07 View session

Merge branch 'main' into services/add-nice-option

fe0f192

Copilot finished reviewing on behalf of devnoname120 November 16, 2025 23:10

Copilot AI reviewed Nov 16, 2025

View reviewed changes

Library/Homebrew/test/service_spec.rb Outdated Show resolved Hide resolved

devnoname120 added 2 commits November 17, 2025 00:21

Shorten line to make linter happy

79c1202

Update raise message in nice test

013f9af

Copilot AI review requested due to automatic review settings November 16, 2025 23:26

Copilot started reviewing on behalf of devnoname120 November 16, 2025 23:26 View session

Copilot finished reviewing on behalf of devnoname120 November 16, 2025 23:28

Copilot AI reviewed Nov 16, 2025

View reviewed changes

devnoname120 requested a review from MikeMcQuaid November 16, 2025 23:43

devnoname120 mentioned this pull request Nov 17, 2025

Add ThrottleInterval option to service (macOS) #21095

Merged

5 tasks

MikeMcQuaid approved these changes Nov 18, 2025

View reviewed changes

MikeMcQuaid enabled auto-merge November 18, 2025 09:30

MikeMcQuaid added this pull request to the merge queue Nov 18, 2025

Merged via the queue into Homebrew:main with commit 3816cee Nov 18, 2025
42 checks passed

Uh oh!

Add Nice option to service #21088

Add Nice option to service #21088

Uh oh!

Conversation

devnoname120 commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Motivation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

MikeMcQuaid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

MikeMcQuaid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

devnoname120 commented Nov 16, 2025 •

edited

Loading