Fix rubocop in vscode and simplify brew install-bundler-gems calls
#21083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors Ruby setup and bundler gem installation to use a new shared helper function ensure-bundle-dependencies(). This simplifies the code and makes the VSCode Ruby LSP setup more maintainable by reusing the same setup functions used elsewhere.
Key Changes:
- Added
ensure-bundle-dependencies()function inutils/ruby.shto centralize bundle dependency checking and installation - Refactored
rubocop.shandsetup-ruby.shto use the new helper function - Simplified
.vscode/ruby-lsp-activate.shto use standard Ruby setup functions instead of custom logic
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/utils/ruby.sh | Added ensure-bundle-dependencies() helper function that checks bundle status and runs install-bundler-gems with appropriate flags |
| Library/Homebrew/dev-cmd/rubocop.sh | Replaced inline bundle check and install logic with call to ensure-bundle-dependencies() |
| Library/Homebrew/cmd/setup-ruby.sh | Replaced inline bundle check and install logic with call to ensure-bundle-dependencies() |
| .vscode/ruby-lsp-activate.sh | Refactored to use standard Ruby setup functions (setup-ruby-path, setup-gem-home-bundle-gemfile, ensure-bundle-dependencies) instead of calling brew directly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
67acd54 to
fcf2429
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue I was having with
rubocopin vscode.The ruby lsp setup in vscode is now much simpler, since it uses the same ruby setup commands we use for other shell commands, so hopefully future changes will be less destructive.
As part of this, I added a new ruby helper function to run
brew install-bundler-gemsif needed, which is used a few times by shell commands and the ruby lsp setup