Update ruby_URLs when using HOMEBREW_ARTIFACT_DOMAIN #21075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
hi @p-linnane not sure what the cadence for a brew tag is ? |
Member
|
Portable Ruby 3.4.7 is not in a stable tag yet, so we don't need to tag a release for this. You should just be able to run |
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21073
When using a HOMEBREW_ARTIFACT_DOMAIN with the new ruby 3.4.7 update, it fails because 3.4.7 does not exist in https://github.com/Homebrew/homebrew-portable-ruby/pkgs/container/portable-ruby%2Fportable-ruby
to fix this, when using HOMEBREW_ARTIFACT_DOMAIN, it should also use the same path as the public repository path
brew lgtm(style, typechecking and tests) with your changes locally?