Use GitHub Actions helper method more consistently. #21066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use this in more places where we were previously just hardcoding the environment variable.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors GitHub Actions environment checks to use a centralized helper method instead of hardcoded environment variable lookups, improving code maintainability and consistency.
- Replaces direct
ENV["GITHUB_ACTIONS"]checks withGitHub::Actions.env_set?helper method - Adds the necessary
require "utils/github/actions"statement totest_bot/step.rb - Removes the now-redundant
in_github_actions?method from theStepclass
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/test_bot/step.rb | Adds require statement for GitHub Actions module, removes local in_github_actions? method, replaces all usages with GitHub::Actions.env_set? |
| Library/Homebrew/test_bot/test_formulae.rb | Replaces ENV["GITHUB_ACTIONS"].blank? and .present? checks with GitHub::Actions.env_set? |
| Library/Homebrew/test_bot/formulae_detect.rb | Replaces direct ENV["GITHUB_ACTIONS"] checks with GitHub::Actions.env_set? |
| Library/Homebrew/test_bot/formulae_dependents.rb | Replaces ENV["GITHUB_ACTIONS"] and .blank? checks with GitHub::Actions.env_set? |
| Library/Homebrew/test_bot/formulae.rb | Replaces ENV["GITHUB_ACTIONS"] and .present? checks with GitHub::Actions.env_set? |
| Library/Homebrew/test_bot.rb | Replaces .present? checks with GitHub::Actions.env_set? |
| Library/Homebrew/formula_auditor.rb | Replaces ENV.fetch("GITHUB_ACTIONS", nil) check with GitHub::Actions.env_set? |
| Library/Homebrew/dev-cmd/test-bot.rb | Replaces .present? check with GitHub::Actions.env_set? |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ZhongRuoyu
approved these changes
Nov 14, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use this in more places where we were previously just hardcoding the environment variable.