tap_auditor: audit synced_versions_formulae.json #21057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds auditing for synced_versions_formulae.json to detect removed formulae that may still be referenced in this list. The change ensures consistency between the synced versions configuration and the actual formulae present in the tap.
Key Changes:
- Added initialization of
@tap_synced_versions_formulaeinstance variable fromtap.synced_versions_formulae - Added audit check for synced_versions_formulae list using the existing
check_formula_listmethod - Properly flattens the nested array structure before validation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6 tasks
p-linnane
approved these changes
Nov 13, 2025
Member
p-linnane
left a comment
There was a problem hiding this comment.
Good catch. I'll open a followup PR to remove pypi_formula_mappings as well since that's gone now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Seems like we don't audit this list as it has removed formulae.