Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Nov 13, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

Our autobump workflow runs bump on each formula of synced group which is unnecessary.

Copilot AI review requested due to automatic review settings November 13, 2025 22:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the autobump workflow by ensuring that when formulae are synced (i.e., their versions are kept in sync), only one formula from each synced group is processed during auto-bump operations, rather than unnecessarily running bump on every formula in the group.

Key Changes:

  • Added logic to filter autobump list when --bump-synced flag is used with formulae
  • Changed from map to filter_map to enable filtering of synced formulae
  • Builds a set of non-primary synced formulae to exclude from processing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 13, 2025 23:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 13, 2025 23:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@p-linnane p-linnane added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit 23ae40c Nov 13, 2025
43 checks passed
@p-linnane p-linnane deleted the bump-once-per-synced branch November 13, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants