Portable Ruby 3.4.7 #21052
Portable Ruby 3.4.7 #21052
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates Homebrew's Portable Ruby from version 3.4.5 to 3.4.7, reverting a previous PR and implementing URL path changes for the portable Ruby distribution.
- Updates Portable Ruby version from 3.4.5 to 3.4.7 across all platforms
- Changes the GitHub Container Registry URL path from
homebrew/portable-ruby/portable-rubytohomebrew/core/portable-ruby - Removes the GitHub releases fallback URL
Reviewed Changes
Copilot reviewed 1 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/vendor/portable-ruby-version | Updates version number to 3.4.7 |
| Library/Homebrew/vendor/portable-ruby-x86_64-linux | Updates SHA hash for x86_64 Linux build |
| Library/Homebrew/vendor/portable-ruby-x86_64-darwin | Updates SHA hash and TAG (el_capitan → catalina) for x86_64 macOS build |
| Library/Homebrew/vendor/portable-ruby-arm64-linux | Updates SHA hash for ARM64 Linux build |
| Library/Homebrew/vendor/portable-ruby-arm64-darwin | Updates SHA hash for ARM64 macOS build |
| Library/Homebrew/cmd/vendor-install.sh | Updates GHCR URL path and removes GitHub releases fallback |
| Library/Homebrew/Gemfile.lock | Updates Ruby version to 3.4.7p58 for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@p-linnane will push a fix here before retrying |
bd4eb35 to
d1b0a68
Compare
|
Maintainers: if/when this is merged: please try to fix forward instead of reverting. I would really like us to get ruby/zlib#109 sorted so we can ship new Ruby versions again. If there's a Ruby critical vulnerability then we need the ability to upgrade. |
We've been getting regular but racey errors when installing Bundler inside Ruby. Also, it shouldn't ever be needed with Portable Ruby as we always vendor Bundler there. Move the relevant logic into Bash and add various fast developer-only checks to ensure that Portable Ruby is installed correctly so we can fix things in CI before they end up putting weird configurations onto users.
d1b0a68 to
d562e44
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 12 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reverts #20836
Let's give this another go and I'll try to actually make a change to attempt a fix here.