Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Nov 13, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

I don't think these symlinks are used anymore since:

And the /usr/local/lib/pkgconfig path is already part of default search path in pkgconf formula.

Copilot AI review requested due to automatic review settings November 13, 2025 13:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes obsolete FUSE pkg-config symlink files that are no longer used by Homebrew's build system.

  • Removes two symlink files in the pkgconfig/fuse/ directory that pointed to /usr/local/lib/pkgconfig
  • Cleans up legacy files that became unnecessary after commit d733512

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Library/Homebrew/os/mac/pkgconfig/fuse/osxfuse.pc Removes obsolete symlink to /usr/local/lib/pkgconfig/osxfuse.pc
Library/Homebrew/os/mac/pkgconfig/fuse/fuse.pc Removes obsolete symlink to /usr/local/lib/pkgconfig/fuse.pc

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
Copy link
Member

@cho-m weird but legit CI failure needs fixed

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit 2afbceb Nov 13, 2025
37 checks passed
@MikeMcQuaid MikeMcQuaid deleted the remove-fuse.pc branch November 13, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants