build: skip libexec metafiles if prefix already has some #21045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libexec can contain resources and installing metafiles can override the correct metafiles (e.g. readme and license). Also, this provides a way to prevent brew from moving files that we want to retain within libexec.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the build process to prevent overwriting metafiles (README, LICENSE, etc.) in the formula prefix when installing from libexec. If the prefix already contains metafiles (installed from buildpath), the PR skips installing additional metafiles from libexec to avoid overriding the correct ones.
Key Changes:
- Added conditional check before installing metafiles from
libexecto prevent overriding existing metafiles in the prefix - The logic checks if any metafiles already exist in
formula.prefixbefore attempting to install fromformula.libexec
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?libexec can contain resources and installing metafiles can override the correct metafiles (e.g. readme and license).
Also, this provides a way to prevent brew from moving files that we want to retain within libexec.
This provides an alternative approach to following issue, rather than modifying
skip_cleanlogic:skip_cleanis used #20922Closes #20922 (MikeMcQuaid edit)