Skip to content

Replace sdk_path_if_needed with sdk_path #21044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MikeMcQuaid merged 1 commit into from
Nov 13, 2025
Merged

Replace sdk_path_if_needed with sdk_path #21044

MikeMcQuaid merged 1 commit into from
Nov 13, 2025

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Nov 13, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

sdk_path_if_needed is now just an alias for sdk_path. Also mark sdk_for_formula, sdk_path and sdk_path_if_needed as public API due to usage in Homebrew/core formulae.

brew/Library/Homebrew/os/mac.rb

Lines 168 to 170 in 0b8a853

def self.sdk_path_if_needed(version = nil)
sdk_path(version)
end

Copilot AI review requested due to automatic review settings November 13, 2025 00:06
@cho-m
Replace sdk_path_if_needed with sdk_path
037142b 
sdk_path_if_needed is now just an alias for sdk_path. Also mark
sdk_for_formula, sdk_path and sdk_path_if_needed as public API due to
usage in Homebrew/core formulae.

This comment was marked as outdated.

Sign in to view

@cho-m cho-m requested a review from Copilot November 13, 2025 00:43

This comment was marked as outdated.

Sign in to view

@cho-m cho-m requested a review from Copilot November 13, 2025 02:02
Copilot AI reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@p-linnane p-linnane requested a review from Copilot November 13, 2025 05:01
Copilot AI reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

MikeMcQuaid
MikeMcQuaid reviewed Nov 13, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks again @cho-m!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit 0b4f0af Nov 13, 2025
55 checks passed
@MikeMcQuaid MikeMcQuaid deleted the sdk_path branch November 13, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

Copilot code review Copilot Copilot left review comments

@p-linnane p-linnane p-linnane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cho-m @MikeMcQuaid @p-linnane