PULL_REQUEST_TEMPLATE: Encourage brew lgtm
#21033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Three boxes to tick is a lot. - With Homebrew 5, there's a `brew lgtm` command that runs all three.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the pull request template by consolidating three separate checklist items for running brew style, brew typecheck, and brew tests into a single item that encourages contributors to use the new brew lgtm command introduced in Homebrew 5, which runs all three checks at once.
Key Changes
- Replaced three separate checklist items for style, typecheck, and tests with a single
brew lgtmitem - Reduced contributor friction by simplifying the PR checklist from 7 items to 5 items
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Should be fixed once #21034 is in main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew lgtmcommand that runs all three.