Improve profiling output for tests #21032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves profiling capabilities for tests by decoupling profiling from serial test execution. Previously, --profile would force tests to run serially, but now it can work with parallel test execution to show the slowest tests per process.
- Removed the condition that forced serial testing when
--profileis used - Added
--profile 3flag to all test configurations in CI to identify slow tests - Simplified CI test execution by removing the retry logic for CodeCov flakiness detection
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/dev-cmd/tests.rb | Removed args.profile from the condition that disables parallel testing |
| manpages/brew.1 | Updated the --profile flag description to reflect parallel execution support |
| docs/Manpage.md | Updated the --profile flag documentation to clarify parallel behavior |
| completions/zsh/_brew | Updated the --profile completion description for zsh |
| completions/fish/brew.fish | Updated the --profile completion description for fish shell |
| .github/workflows/tests.yml | Added --profile 3 to test flags and removed retry logic for flakiness detection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Don't force serial testing when profiling - Add `--profile` flag to tests run in CI - Don't try to repeatedly rerun tests to detect flakiness when CodeCov is enabled because it doesn't seem to be a problem anymore
0de35b3 to
c2c8d0f
Compare
p-linnane
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--profileflag to tests run in CI