cmd/deps: allow pruning deps tree for TestBot#20817
Merged
MikeMcQuaid merged 2 commits intomainfrom Oct 6, 2025
Merged
Conversation
d3ae90e to
6ad1461
Compare
38 tasks
Member
Author
|
Added some integration tests. Only takes a couple seconds locally ❯ brew tests --only cmd/deps
Randomized with seed 7617
1 process for 1 spec, ~ 1 spec per process
.....
Took 2 seconds |
6d447a7 to
a648bb2
Compare
a648bb2 to
5827251
Compare
MikeMcQuaid
approved these changes
Oct 6, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks good! Note if this is literally only for brew test-bot we should consider inline it there rather than shelling out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Mainly required for Qt where
brew deps --treeon Linux is slow when using split out modules (Homebrew/homebrew-core#246844). When saved in a file it is over 8GB, which causes OOM on GitHub runner and seems to take hours on self-hosted (locally takes ~30min when dumping to a file)I think we run this in CI to catch circular dependencies, so can ignore already tested parts.
I've also seen CI runner spend 5+ minutes on
brew deps --treefor other formulae so may help speed those up too.Later on, may see if there is any performance issue of
brew deps --treeor expected when storing in memory.For
qtwebengineoutput tree size comparisonqtdeclarativetime comparison (easier to test thanqtwebengine)