formulary: do not allow using the cache when forbidding paths#20487
Merged
MikeMcQuaid merged 2 commits intomainfrom Aug 18, 2025
Merged
formulary: do not allow using the cache when forbidding paths#20487MikeMcQuaid merged 2 commits intomainfrom
MikeMcQuaid merged 2 commits intomainfrom
Conversation
0e4832e to
b30d13c
Compare
MikeMcQuaid
reviewed
Aug 18, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks! Should be able to land something like this, just need to tweak approach a bit.
MikeMcQuaid
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implicitly-set
HOMEBREW_FORBID_PACKAGES_FROM_PATHSis more to point non-developers away from paths as they're not well supported, explicitly-setHOMEBREW_FORBID_PACKAGES_FROM_PATHSis a security feature.Since the cache can contain arbitrary downloads, we shouldn't allow the cache if
HOMEBREW_FORBID_PACKAGES_FROM_PATHSis explicitly set.