formulary: improve/loosen path rejection logic.#20457
Merged
MikeMcQuaid merged 1 commit intomainfrom Aug 14, 2025
Merged
Conversation
- Don't check if the `realpath` includes `/`: it always will. Instead, see if the originally user-passed `ref` includes `/` or ends with `.rb`. - Always raise an error message, don't silently return.
This was referenced Aug 14, 2025
bevanjkay
approved these changes
Aug 14, 2025
|
i'm still getting the same error from yesterday i just reran my job from the previous day when i first reported this issue, and the job did not successfully run https://github.com/ipatch/homebrew-us-05/actions/runs/16951771122/job/48113491964 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
realpathincludes/: it always will. Instead, see if the originally user-passedrefincludes/or ends with.rb.Fixes #20441
Fixes #20448
Fixes #20452