formula_auditor: allow pkg-config alias for pkgconf migration#18675
Merged
formula_auditor: allow pkg-config alias for pkgconf migration#18675
pkg-config alias for pkgconf migration#18675Conversation
6 tasks
MikeMcQuaid
approved these changes
Oct 31, 2024
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Good to merge once there's a comment!
04d1747 to
347e946
Compare
p-linnane
approved these changes
Nov 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?We've discussed migrating
pkg-configtopkgconfa couple times, e.g. Homebrew/homebrew-core#194885One of requirements is retaining compatibility with wide usage of
depends_on "pkg-config"which seems to be best handled through an alias and this audit exception.