Skip to content

extend/pathname: fix text_executable? regex#15586

Merged
Bo98 merged 1 commit into
Homebrew:masterfrom
Bo98:text-executable-regex
Jun 25, 2023
Merged

extend/pathname: fix text_executable? regex#15586
Bo98 merged 1 commit into
Homebrew:masterfrom
Bo98:text-executable-regex

Conversation

@Bo98

@Bo98 Bo98 commented Jun 25, 2023

Copy link
Copy Markdown
Member

Otherwise we might match binary sequences that happen to be 0A 23 21 <regular non-space character>.

@Bo98 Bo98 merged commit bb23116 into Homebrew:master Jun 25, 2023
@MikeMcQuaid

Copy link
Copy Markdown
Member

Makes sense, thanks again @Bo98!

@Bo98 Bo98 deleted the text-executable-regex branch June 25, 2023 18:43
@github-actions github-actions Bot added the outdated PR was locked due to age label Jul 26, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants