Cask update error msgs #1312
Merged
Cask update error msgs #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawshooah
suggested changes
Oct 17, 2016
Contributor
Author
There was a problem hiding this comment.
Without the newline the error message and the instructions get concatenated together. Would it be better to change line 155 in cli.rb to add a newline to the end of the error message?
Contributor
There was a problem hiding this comment.
Yes, that sounds like more of an issue with the call site than with the message itself.
jawshooah
approved these changes
Oct 17, 2016
96eee77 to
87c5e6b
Compare
87c5e6b to
5071271
Compare
Member
There was a problem hiding this comment.
I'd use “Follow” instead of “Try following”.
Contributor
|
@narendasan I cleaned up your branch to try and fix the CI errors, but it looks like it didn't work. You'll need to |
e94ce66 to
c7ac466
Compare
Contributor
Author
|
I have the required tests working but I am not sure what I need to modify for the codecov checks to pass |
reitermarkus
approved these changes
Oct 18, 2016
e758702 to
5f29297
Compare
jawshooah
approved these changes
Oct 18, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?This PR should address Homebrew/homebrew-cask#25127
The message printed when brew cask errors out has been changed from a generic command to pointing at the brew cask documentation on github so that instructions can be changed outside of brew.
There are 2 questions that I have (that should not effect this PR):
https://github.com/Homebrew/brew/blob/master/Library/Homebrew/cask/lib/hbc/artifact/uninstall_base.rb#L90 be changed as well?
brew cask-testsfails on the version test, but it does that on master as well. Is this a known issue?