curl: echo any cookies received on a redirect #11790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Aug 10, 2021
| rescue ErrorDuringExecution => e | ||
| if e.status.exitstatus == 22 && resolved_url != url && is_redirection | ||
| ohai "Downloading from #{url}" | ||
| resolved_url = url |
Member
There was a problem hiding this comment.
Can you explain why this fixes things? It feels like a strange fix to override our internal state about what the original URL was like this. Thanks!
Contributor
Author
There was a problem hiding this comment.
I don't quite remember... It's technically not needed though, so I'll remove it.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
08ba1e4 to
7d0a367
Compare
MikeMcQuaid
approved these changes
Sep 1, 2021
Member
|
Thanks again @FnControlOption! |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Using a browser or
wget, opening https://www.crushftp.com/early10/CrushFTP10.zip sets some cookies and then redirects to https://www.crushftp.com/CrushFTP10.zipUsing
curlor attempting to directly download https://www.crushftp.com/CrushFTP10.zip fails because it requires the cookies that are set by https://www.crushftp.com/early10/CrushFTP10.zipAs seen in Homebrew/homebrew-cask#109237, these cookies can be set for
brew installbutbrew auditstill fails. This can be fixed by adding--cookie-jar /dev/nullto thecurlarguments, which makes the cookies persist even after a redirect.Additionally, I've added a
retrytodownload_strategy.rbthat makes it unnecessary to set cookies in Homebrew/homebrew-cask#109237.