Fix thinking block finalization on stream errors and restarts#1078
Merged
Hmbown merged 1 commit intoHmbown:mainfrom May 7, 2026
Merged
Fix thinking block finalization on stream errors and restarts#1078Hmbown merged 1 commit intoHmbown:mainfrom
Hmbown merged 1 commit intoHmbown:mainfrom
Conversation
Finalize active thinking blocks before resetting stream state. This prevents engine errors from leaving thinking entries stuck in streaming state, and preserves pending thinking text when a new thinking block starts. Adds regression coverage for both paths.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes RC1 and RC2 from #861.
RC1: engine error cleanup reset the streaming state without finalizing the active thinking entry first. That could
leave the visible thinking block stuck in
streamingstate.RC2: a new
ThinkingStartedevent resetStreamingStateeven if the previous thinking block still had pendingbuffered text. That could silently drop the tail of the previous thinking content.
This change finalizes the active thinking block before stream resets, both on engine errors and when a new
thinking block starts.
Testing
cargo test --all-featurescargo fmt --all -- --checkcargo clippy --all-targets --all-featuresChecklist