test(shell): #2528 widen background completion wait#2765
Conversation
Widen the focused background-shell completion wait used by shell tests so slow Windows runners do not leave lightweight background commands reported as Running before assertions fire. Refs #2525 Refs #2526 Harvested from PR #2528 by @cyq1017 Co-authored-by: cyq1017 <61975706+cyq1017@users.noreply.github.com>
There was a problem hiding this comment.
Hmbown has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
Code Review
This pull request introduces a new constant BACKGROUND_COMPLETION_WAIT_MS set to 30,000 milliseconds in the shell tests. It updates the wait_for_completed_shell function and the test_completed_background_shell_releases_process_handles test to use this constant instead of hardcoded timeout values. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
Credit
.github/AUTHOR_MAPVerification
cargo fmt --all -- --checkcargo test -p codewhale-tui --bin codewhale-tui --locked test_background_execution -- --nocapturecargo test -p codewhale-tui --bin codewhale-tui --locked test_completed_background_shell_releases_process_handles -- --nocapturecargo clippy -p codewhale-tui --bin codewhale-tui --locked -- -D warningsgit diff --check./scripts/release/check-versions.shpython3 scripts/check-coauthor-trailers.py --range origin/codex/v0.9.0-stewardship..HEAD