fix(pricing): extend V4 Pro 75% discount expiry to 2026-05-31 15:59 UTC#270
Conversation
DeepSeek extended the promotional discount past the original 2026-05-05 cutoff. Without this update the TUI would have started showing 4× the actual billed cost on May 6. Source: https://api-docs.deepseek.com/quick_start/pricing — "extended until 2026/05/31 15:59 UTC". Adds a regression test pinning the new active window so a future revert to the May 5 date trips the suite immediately. Closes #267
There was a problem hiding this comment.
Code Review
This pull request extends the DeepSeek V4 Pro promotional discount expiry from May 5, 2026, to May 31, 2026, within the TUI pricing logic and updates the changelog accordingly. The changes include updating the expiry timestamp, adjusting existing tests, and adding a new regression test. Feedback suggests renaming the new regression test to more accurately reflect that it verifies the discount remains active after the original expiry date, as the current name is misleading regarding the timestamp used.
| } | ||
|
|
||
| #[test] | ||
| fn v4_pro_discount_still_applies_just_before_old_may5_expiry() { |
There was a problem hiding this comment.
The test name v4_pro_discount_still_applies_just_before_old_may5_expiry is misleading. The test implementation uses a timestamp of May 6th (2026, 5, 6, 0, 0, 0), which is actually after the previous expiry date of May 5th. The purpose of this regression test is to verify that the discount remains active in the newly extended window (i.e., it still applies even though it would have expired under the old logic). A more accurate name would be v4_pro_discount_still_applies_after_old_may5_expiry.
| fn v4_pro_discount_still_applies_just_before_old_may5_expiry() { | |
| fn v4_pro_discount_still_applies_after_old_may5_expiry() { |
| ### Fixed | ||
| - **V4 Pro discount expiry extended** (#267) — DeepSeek extended the V4 Pro 75% | ||
| promotional discount from 2026-05-05 15:59 UTC to 2026-05-31 15:59 UTC. Without | ||
| this update the TUI would have started showing 4× the actual billed cost on | ||
| May 6 onwards. Verified at https://api-docs.deepseek.com/quick_start/pricing. |
There was a problem hiding this comment.
🟡 README files still show old discount expiry date (2026-05-05) after code was updated to 2026-05-31
The PR updates the V4 Pro discount expiry from 2026-05-05 to 2026-05-31 in crates/tui/src/pricing.rs and CHANGELOG.md, but the same date string was not updated in README.md:254 (*\*DeepSeek lists the Pro rates above as a limited-time 75% discount valid until 2026-05-05 15:59 UTC…*) and README.zh-CN.md:216 (*DeepSeek 标注的 Pro 价格是限时 75% 折扣，有效期到 2026-05-05 15:59 UTC…*). Users reading either README will see the old May 5 expiry and may incorrectly believe the discount has already expired or that the TUI's cost estimates are wrong after May 5.
Prompt for agents
The PR updated the V4 Pro discount expiry date from 2026-05-05 to 2026-05-31 in crates/tui/src/pricing.rs (the source of truth) and in CHANGELOG.md, but two README files still reference the old date:
1. README.md line 254: contains '2026-05-05 15:59 UTC' — change to '2026-05-31 15:59 UTC'
2. README.zh-CN.md line 216: contains '2026-05-05 15:59 UTC' — change to '2026-05-31 15:59 UTC'
Both are simple string replacements of the date in an italicized footnote about the discount validity period.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Pull request overview
Updates the DeepSeek V4 Pro pricing estimator to match the newly extended 75% promotional discount window, ensuring the TUI’s cost estimates remain accurate through the end of May 2026.
Changes:
- Extend the hard-coded V4 Pro 75% discount expiry timestamp to 2026-05-31 15:59 UTC.
- Update pricing tests to reflect the new expiry and add a regression test guarding against reverting to the old May 5 date.
- Add an Unreleased changelog entry documenting the pricing correction.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/tui/src/pricing.rs | Updates the discount cutoff and adjusts/adds tests to lock in the new discount window. |
| CHANGELOG.md | Documents the extended discount expiry in the Unreleased section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| this update the TUI would have started showing 4× the actual billed cost on | ||
| May 6 onwards. Verified at https://api-docs.deepseek.com/quick_start/pricing. |
| - **V4 Pro discount expiry extended** (#267) — DeepSeek extended the V4 Pro 75% | ||
| promotional discount from 2026-05-05 15:59 UTC to 2026-05-31 15:59 UTC. Without | ||
| this update the TUI would have started showing 4× the actual billed cost on | ||
| May 6 onwards. Verified at https://api-docs.deepseek.com/quick_start/pricing. |
| fn v4_pro_discount_still_applies_just_before_old_may5_expiry() { | ||
| // Regression for #267: extension to 2026-05-31 15:59 UTC. | ||
| let after_old_expiry = Utc.with_ymd_and_hms(2026, 5, 6, 0, 0, 0).single().unwrap(); | ||
| let pricing = pricing_for_model_at("deepseek-v4-pro", after_old_expiry).unwrap(); |
Summary
v4_pro_discount_still_applies_just_before_old_may5_expiry) that pins the new active window so a revert to the May 5 date trips the suite immediately.Closes #267.
Test plan
cargo test -p deepseek-tui --bin deepseek-tui --locked pricing— 5/5 passcargo fmt --all -- --checkcargo clippy -p deepseek-tui --all-targets --locked -- -D warnings🤖 Generated with Claude Code