Skip to content

chore(release): prepare v0.8.38#1698

Merged
Hmbown merged 1 commit into
mainfrom
work/v0.8.38-approval-denial-exact
May 15, 2026
Merged

chore(release): prepare v0.8.38#1698
Hmbown merged 1 commit into
mainfrom
work/v0.8.38-approval-denial-exact

Conversation

@Hmbown

@Hmbown Hmbown commented May 15, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes #1617
Fixes #1685

Contributor credit

Checks

  • cargo fmt --all -- --check
  • git diff --check
  • ./scripts/release/check-versions.sh
  • cargo test -p deepseek-tui --bin deepseek-tui approval_cache --locked
  • cargo test -p deepseek-tui --bin deepseek-tui session_denied_cache_matches_only_approval_key --locked
  • cargo test -p deepseek-tui --bin deepseek-tui session_approved_cache_keeps_tool_name_session_grants --locked
  • cargo test -p deepseek-tui --bin deepseek-tui batch_tool_calls_preserve_all_tool_use_indices --locked
  • cargo test -p deepseek-tui --bin deepseek-tui diagnostics_schema_has_empty_required_array --locked
  • cargo clippy -p deepseek-tui --bin deepseek-tui --tests --locked -- -D warnings
  • cargo check --workspace --all-targets --locked
  • node --test npm/deepseek-tui/test/install.test.js npm/deepseek-tui/test/postinstall.test.js npm/deepseek-tui/test/run.test.js

No tag, publish, GitHub Release, crates/npm/GHCR/CNB/Homebrew release, or external package push is included.

Copilot AI review requested due to automatic review settings May 15, 2026 22:51

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project version to 0.8.38 and implements a more granular tool approval caching system. The approval key generation for file and shell tools has been updated to use canonical argument fingerprints instead of lossy prefixes, ensuring that denials are scoped to specific calls. Additionally, the TUI logic was refactored to handle session-wide approvals while maintaining specific-call denials. I have no feedback to provide as there were no review comments.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Hmbown Hmbown force-pushed the work/v0.8.38-approval-denial-exact branch from 351d5cd to d0f70a6 Compare May 15, 2026 22:57
@Hmbown Hmbown force-pushed the work/v0.8.38-approval-denial-exact branch from d0f70a6 to d3ef4cb Compare May 15, 2026 23:00
@Hmbown Hmbown merged commit 5401eaa into main May 15, 2026
12 checks passed
@Hmbown Hmbown deleted the work/v0.8.38-approval-denial-exact branch May 15, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

diagnostics tool: null passed instead of array, causing 400 on every turn Bug in deny tool use

2 participants