fix(tui): detect macOS light mode for system theme#1674
Closed
Aitensa wants to merge 2 commits into
Closed
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Owner
|
Thanks for the macOS system-theme fallback. The fix was harvested into v0.8.39 via #1734 and credited in the changelog, so I am closing this PR to keep the queue clean. Please reopen if latest still detects dark mode on macOS Light with Ghostty and no COLORFGBG. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
theme = "system"cannot infer light/dark mode fromCOLORFGBGAppleInterfaceStylekey as Light mode, matching macOS defaultsTesting
cargo fmt --all --checkcargo test --all-featurescargo clippy --all-targets --all-featurescargo test -p deepseek-tui --bin deepseek-tui palette_mode_ --lockedcargo test -p deepseek-tui --bin deepseek-tui apple_interface_style_maps_dark_and_missing_key_to_expected_modes --lockedcargo test -p deepseek-tui --bin deepseek-tui ui_theme_selects_light_variant --lockedChecklist
Fixes #1670.