fix(approval): fingerprint generic tool denials#1623
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the approval cache to include a hash of the tool's input in the cache key for generic tools, ensuring that different inputs for the same tool result in unique keys. The implementation introduces a hash_json_input helper function and updates the documentation and unit tests accordingly. I have no feedback to provide as there were no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1617.
Summary
edit_file/generic approval from blocking every future request of that tool typeVerification
Release Safety