Recovered diff from Hmbown/DeepSeek-TUI#1443#1471
Closed
CrepuscularIRIS wants to merge 1 commit into
Closed
Conversation
On platforms where mouse capture is disabled by default (Windows CMD / legacy conhost), the terminal sends mouse-wheel events as Up/Down arrow- key sequences. Without composer_arrows_scroll those sequences cycle the input history instead of scrolling the transcript (Hmbown#1443). Set the default for composer_arrows_scroll to !use_mouse_capture so that terminals that forward wheel events as arrows get page-scrolling out of the box, while terminals with real mouse capture (Windows Terminal, Linux, macOS) keep the existing history-navigation default. The explicit [tui] composer_arrows_scroll config key still overrides the derived default in both directions. Also enable mouse capture by default for ConEmu/Cmder (ConEmuPID env var), which handles VT mouse-mode reporting cleanly, giving those users in-app scrolling without needing --mouse-capture. Fixes Hmbown#1443 Signed-off-by: CrepuscularIRIS <serenitygp@qq.com>
885f47b to
0d4fe76
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the default behavior of the composer_arrows_scroll setting in the TUI application, changing it to default to true when mouse capture is disabled. This change ensures that terminals which map mouse-wheel events to arrow keys correctly trigger transcript scrolling instead of input history navigation. The update includes adjustments to existing tests and the addition of new test cases to verify the default behavior with and without mouse capture. I have no feedback to provide as there were no review comments to evaluate.
Contributor
Author
|
Auto cleanup: stale AGC/placeholder/open PR interfering with duplicate-gate; closing to unblock candidate testing. |
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovered diff from #1443
AutoGHClaw author timed out at the ACP boundary (Bug 73), but recovered issue diff successfully from local artifacts after ACP timeout. Bug 76 recovery: continuing review on recovered artifact. If push state is incomplete, run_open will surface that honestly.