Make composer arrows navigate input history#1138
Merged
Merged
Conversation
Make plain Up/Down navigate composer input history instead of scrolling the transcript from an empty composer. Keep menu overlays in control of arrow keys, preserve existing transcript scroll shortcuts, and support word-wise cursor movement with Ctrl or Alt/Option Left/Right.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plain Up/Down previously scrolled the transcript when the composer was empty, so users could not use the default arrow keys to browse input
history. This made the most common composer action require Ctrl+Up/Down instead.
This change makes plain Up/Down navigate composer input history by default, while keeping slash/mention menus in control of their own arrow
navigation. Existing transcript scroll shortcuts such as PageUp/PageDown and Alt/Super+Up/Down are preserved.
It also adds word-wise composer cursor movement for Ctrl+Left/Right and Alt/Option+Left/Right, which matches common terminal/editor
behavior and works better on macOS terminals.
fixes: #1117
Testing
cargo test --all-featurescargo fmt --all -- --checkcargo clippy --all-targets --all-featuresChecklist