chore: remove dead code

ansgarbecker · ansgarbecker · commit fa4a14ac149a · 2025-12-22T11:16:09.000+01:00
No longer used functions: GetShellFolder, GetSystemImageList, GetSystemImageIndex, GetProductInfo, GetCurrentPackageFullName, ToggleCheckBoxWithoutClick, WebColorStrToColorDef
diff --git a/source/apphelpers.pas b/source/apphelpers.pas
@@ -341,7 +341,6 @@   TAppSettings = class(TObject)
   procedure StripNewLines(var txt: String; Replacement: String=' ');
   function GetLineBreak(LineBreakIndex: TLineBreaks): String;
   procedure RemoveNullChars(var Text: String; var HasNulls: Boolean);
-  //function GetShellFolder(FolderId: TGUID): String;
   function ValidFilename(Str: String): String;
   function FormatNumber( str: String; Thousands: Boolean=True): String; Overload;
   function UnformatNumber(Val: String): String;
@@ -412,23 +411,17 @@   TAppSettings = class(TObject)
   function f_(const Pattern: string; const Args: array of const): string;
   function GetOutputFilename(FilenameWithPlaceholders: String; DBObj: TDBObject): String;
   function GetOutputFilenamePlaceholders: TStringList;
-  //function GetSystemImageList: TImageList;
-  //function GetSystemImageIndex(Filename: String): Integer;
   function GetExecutableBits: Byte;
   procedure Help(Sender: TObject; Anchor: String);
   function PortOpen(Port: Word): Boolean;
-  //function GetProductInfo(dwOSMajorVersion, dwOSMinorVersion, dwSpMajorVersion, dwSpMinorVersion: DWORD; out pdwReturnedProductType: DWORD): BOOL stdcall; external kernel32 delayed;
-  //function GetCurrentPackageFullName(out Len: Cardinal; Name: PWideChar): Integer; stdcall; external kernel32 delayed;
   function GetThemeColor(Color: TColor): TColor;
   function ThemeIsDark(ThemeName: String=''): Boolean;
   function ProcessExists(pid: Cardinal; ExeNamePattern: String): Boolean;
-  //procedure ToggleCheckBoxWithoutClick(chk: TCheckBox; State: Boolean);
   function SynCompletionProposalPrettyText(ImageIndex: Integer; LeftText, CenterText, RightText: String; LeftColor: TColor=-1; CenterColor: TColor=-1; RightColor: TColor=-1): String;
   function PopupComponent(Sender: TObject): TComponent;
   function IsWine: Boolean;
   function DirSep: Char;
   procedure FindComponentInstances(BaseForm: TComponent; ClassType: TClass; var List: TObjectList<TComponent>);
-  //function WebColorStrToColorDef(WebColor: string; Default: TColor): TColor;
   function GetOS: String;
   function UserAgent(OwnerComponent: TComponent): String;
   function CodeIndent(Steps: Integer=1): String;
@@ -954,25 +947,6 @@ procedure RemoveNullChars(var Text: String; var HasNulls: Boolean);
 end;
 
 
-{***
-  Get the path of a Windows(r)-shellfolder, specified by a KNOWNFOLDERID constant
-  @see https://docs.microsoft.com/en-us/windows/win32/shell/knownfolderid
-  @param TGUID constant
-  @return string Path
-}
-{function GetShellFolder(FolderId: TGUID): String;
-var
-  Path: PWideChar;
-begin
-  if Succeeded(SHGetKnownFolderPath(FolderId, 0, 0, Path)) then begin
-    Result := Path;
-  end else begin
-    Result := EmptyStr;
-  end;
-end;}
-
-
-
 {***
   Remove special characters from a filename
 
@@ -2754,35 +2728,6 @@ function GetOutputFilenamePlaceholders: TStringList;
 end;
 
 
-{function GetSystemImageList: TImageList;
-var
-  Info: TSHFileInfo;
-  ImageListHandle: Cardinal;
-begin
-  // Create shared imagelist once and use in TPopupMenu and TVirtualTree or whatever
-  if SystemImageList = nil then begin
-    ImageListHandle := SHGetFileInfo('', 0, Info, SizeOf(Info), SHGFI_SYSICONINDEX or SHGFI_SMALLICON);
-    if ImageListHandle <> 0 then begin
-      SystemImageList := TImageList.Create(MainForm);
-      SystemImageList.Handle := ImageListHandle;
-      SystemImageList.ShareImages := true;
-      SystemImageList.DrawingStyle := dsTransparent;
-    end;
-  end;
-  Result := SystemImageList;
-end;}
-
-
-{function GetSystemImageIndex(Filename: String): Integer;
-var
-  Info: TSHFileInfo;
-begin
-  // Return image index of shared system image list, for a given filename
-  SHGetFileInfo(PChar(Filename), 0, Info, SizeOf(Info), SHGFI_SYSICONINDEX or SHGFI_TYPENAME);
-  Result := Info.iIcon;
-end;}
-
-
 function GetExecutableBits: Byte;
 begin
   {$IfDef CPU32}
@@ -2866,17 +2811,6 @@ function ProcessExists(pid: Cardinal; ExeNamePattern: String): Boolean;
 end;
 
 
-{procedure ToggleCheckBoxWithoutClick(chk: TCheckBox; State: Boolean);
-var
-  ClickEvent: TNotifyEvent;
-begin
-  ClickEvent := chk.OnClick;
-  chk.OnClick := nil;
-  chk.Checked := State;
-  chk.OnClick := ClickEvent;
-end;}
-
-
 function SynCompletionProposalPrettyText(ImageIndex: Integer; LeftText, CenterText, RightText: String;
   LeftColor: TColor=-1; CenterColor: TColor=-1; RightColor: TColor=-1): String;
 const
@@ -2954,15 +2888,6 @@ procedure FindComponentInstances(BaseForm: TComponent; ClassType: TClass; var Li
   end;
 end;
 
-{function WebColorStrToColorDef(WebColor: string; Default: TColor): TColor;
-begin
-  try
-    Result := WebColorStrToColor(WebColor);
-  except
-    Result := Default;
-  end;
-end;}
-
 
 function GetOS: String;
 begin
diff --git a/source/insertfiles.pas b/source/insertfiles.pas
@@ -118,7 +118,6 @@ implementation
 procedure TfrmInsertFiles.FormCreate(Sender: TObject);
 begin
   HasSizeGrip := True;
-  //ListFiles.Images := GetSystemImageList;
   //DragAcceptFiles(Handle, True);
   FixVT(ListFiles);
   FixVT(ListColumns);
@@ -384,7 +383,6 @@ procedure TfrmInsertFiles.AddFile(Filename: String);
     Exit;
   FileInfo := TFileInfo.Create;
   FileInfo.Filename := Filename;
-  //FileInfo.ImageIndex := GetSystemImageIndex(Filename);
   FileInfo.Size := _GetFileSize(Filename);
   rx := TRegExpr.Create;
   // Decide if file is binary by excluding common text format file extensions
diff --git a/source/main.pas b/source/main.pas
@@ -5089,9 +5089,6 @@ procedure TMainForm.PopupQueryLoadPopup(Sender: TObject);
   // Fill the popupQueryLoad menu
   popupQueryLoad.Items.Clear;
 
-  // Apply shared system image list
-  //popupQueryLoad.Images := GetSystemImageList;
-
   // Snippets
   SetSnippetFilenames;
   SnippetsFolder := TMenuItem.Create(popupQueryLoad);
@@ -5119,7 +5116,6 @@ procedure TMainForm.PopupQueryLoadPopup(Sender: TObject);
     Item := TMenuItem.Create( popupQueryLoad );
     Item.Caption := IntToStr(j) + ' ' + Filename;
     Item.OnClick := popupQueryLoadClick;
-    //Item.ImageIndex := GetSystemImageIndex(Filename);
     popupQueryLoad.Items.Add(Item);
   end;
 
