feat: recreate previous state of trigger after realizing the user edited code has errors

ansgarbecker · ansgarbecker · commit e7e5e11cb45b · 2026-01-13T15:52:30.000+01:00
Refs #2348
diff --git a/source/trigger_editor.pas b/source/trigger_editor.pas
@@ -228,6 +228,8 @@ procedure TfrmTriggerEditor.comboDefinerDropDown(Sender: TObject);
 
 
 function TfrmTriggerEditor.ApplyModifications: TModalResult;
+var
+  OldCreateCode: String;
 begin
   // Edit mode means we drop the trigger and recreate it, as there is no ALTER TRIGGER.
   Result := mrOk;
@@ -237,7 +239,9 @@ function TfrmTriggerEditor.ApplyModifications: TModalResult;
     // So, we take the risk of loosing the trigger for cases in which the user has SQL errors in
     // his statement. The user must fix such errors and re-press "Save" while we have them in memory,
     // otherwise the trigger attributes are lost forever.
+    OldCreateCode := '';
     if ObjectExists then try
+      OldCreateCode := DBObject.CreateCode;
       DBObject.Connection.Query('DROP TRIGGER '+DBObject.Connection.QuoteIdent(DBObject.Name));
     except
     end;
@@ -253,6 +257,8 @@ function TfrmTriggerEditor.ApplyModifications: TModalResult;
     on E:EDbError do begin
       ErrorDialog(E.Message);
       Result := mrAbort;
+      if not OldCreateCode.IsEmpty then
+        DBObject.Connection.Query(OldCreateCode);
     end;
   end;
 end;
