fix: wrong use of Copy(), which is one-based not zero-based, and remove translated appendix to snipped log message which may use critical chars and confuse SynEdit

ansgarbecker · ansgarbecker · commit e3fc3f5ff6ef · 2026-03-06T10:55:38.000+01:00
Refs #48
diff --git a/source/main.pas b/source/main.pas
@@ -5561,9 +5561,7 @@ procedure TMainForm.LogSQL(Msg: String; Category: TDBLogCategory=lcInfo; Connect
       snip := (MaxLineWidth > 0) and (Len > MaxLineWidth);
       IsSQL := LogItem.Category in [lcSQL, lcUserFiredSQL];
       if snip then begin
-        Msg :=
-          Copy(Msg, 0, MaxLineWidth) +
-          '/* '+f_('large SQL query (%s), snipped at %s characters', [FormatByteNumber(Len), FormatNumber(MaxLineWidth)]) + ' */';
+        Msg := Copy(Msg, 1, MaxLineWidth) + '...';
       end else if (not snip) and IsSQL then
         Msg := Msg + Delimiter;
       if not IsSQL then
@@ -6854,7 +6852,7 @@ procedure TMainForm.SynCompletionProposalExecute(Sender: TObject);
     dbname := '';
     tblname := LeftToken;
     if Pos('.', tblname) > -1 then begin
-      dbname := Copy(tblname, 0, Pos('.', tblname)-1);
+      dbname := Copy(tblname, 1, Pos('.', tblname)-1);
       tblname := Copy(tblname, Pos('.', tblname)+1, Length(tblname));
     end;
     // db and table name may already be quoted
diff --git a/source/sqlhelp.pas b/source/sqlhelp.pas
@@ -141,7 +141,7 @@ procedure TfrmSQLhelp.treeTopicsFocusChanged(Sender: TBaseVirtualTree; Node: PVi
   if VT.HasChildren[VT.FocusedNode] then
     Exit;
   FKeyword := VT.Text[VT.FocusedNode, VT.FocusedColumn];
-  lblKeyword.Caption := Copy(FKeyword, 0, 100);
+  lblKeyword.Caption := Copy(FKeyword, 1, 100);
   MemoDescription.Lines.Clear;
   MemoExample.Lines.Clear;
   Caption := DEFAULT_WINDOW_CAPTION;
diff --git a/source/texteditor.pas b/source/texteditor.pas
@@ -429,7 +429,7 @@ procedure TfrmTextEditor.btnLoadTextClick(Sender: TObject);
     Screen.Cursor := crHourglass;
     MemoText.Text := ReadTextFile(d.FileName, MainForm.GetEncodingByName(d.Encodings[d.EncodingIndex]));
     if (FMaxLength > 0) and (Length(MemoText.Text) > FMaxLength) then
-      MemoText.Text := copy(MemoText.Text, 0, FMaxLength);
+      MemoText.Text := Copy(MemoText.Text, 1, FMaxLength);
     AppSettings.WriteInt(asFileDialogEncoding, d.EncodingIndex, Self.Name);
   finally
     Screen.Cursor := crDefault;
