fix: a few more compiler hints and warnings

ansgarbecker · ansgarbecker · commit e18b3dbc7e79 · 2026-01-10T13:20:45.000+01:00
diff --git a/source/apphelpers.pas b/source/apphelpers.pas
@@ -1339,6 +1339,7 @@ procedure OpenTextFile(const Filename: String; out Stream: TFileStream; var Enco
   // If the file contains a BOM, advance the stream's position
   BomLen := 0;
   if Length(Encoding.GetPreamble) > 0 then begin
+    Header := [];
     SetLength(Header, Length(Encoding.GetPreamble));
     Stream.ReadBuffer(Pointer(Header)^, Length(Header));
     if CompareMem(Header, Encoding.GetPreamble, SizeOf(Header)) then
@@ -1369,7 +1370,7 @@ function DetectEncoding(Stream: TStream): TEncoding;
   OldPos := Stream.Position;
   Stream.Position := 0;
   try
-    ReadCount := Stream.Read(Buffer, SizeOf(Buffer));
+    ReadCount := Stream.Read({%H-}Buffer, SizeOf(Buffer));
   finally
     Stream.Position := OldPos;
   end;
@@ -1401,6 +1402,7 @@ function ReadTextfileChunk(Stream: TFileStream; Encoding: TEncoding; ChunkSize:
   if (ChunkSize = 0) or (ChunkSize > DataLeft) then
     ChunkSize := DataLeft;
 
+  Bytes := [];
   SetLength(Bytes, ChunkSize);
   Stream.ReadBuffer(Bytes[0], Length(Bytes));
   Result := Encoding.GetAnsiString(Bytes);
@@ -2798,6 +2800,7 @@ function IsPortFree(APort: Word; const AIP: string = '127.0.0.1'): Boolean;
     Exit;
 
   try
+    addr := Default(TInetSockAddr);
     FillChar(addr, SizeOf(addr), 0);
     addr.sin_family := AF_INET;
     addr.sin_port   := htons(APort);
@@ -3023,7 +3026,7 @@ procedure CopyImageList(SourceList, TargetList: TImageList; AppendDisabled: Bool
   TargetList.RegisterResolutions(Resolutions);
   for i:=0 to SourceList.Count-1 do
   begin
-    SetLength(TempBitmapList, 0);
+    TempBitmapList := [];
     SetLength(TempBitmapList, Length(Resolutions));
     for ResIdx:=Low(Resolutions) to High(Resolutions) do begin
       ResWidth := Resolutions[ResIdx];
diff --git a/source/connections.pas b/source/connections.pas
@@ -939,6 +939,7 @@ procedure Tconnform.ListSessionsDragDrop(Sender: TBaseVirtualTree;
   else
     ParentNode := TargetNode;
 
+  ParentKey := '';
   SiblingSessions := NodeSessionNames(ParentNode, ParentKey);
   // Test if target folder has an equal named node
   if SiblingSessions.IndexOf(FocusedSess.SessionName) > -1 then
diff --git a/source/dbconnection.pas b/source/dbconnection.pas
@@ -1259,6 +1259,7 @@ function TSecureShellCmd.ReadPipe(const Pipe: TInputPipeStream): String;
     BytesAvailable := Pipe.NumBytesAvailable;
     if BytesAvailable = 0 then
       Break;
+    Buffer := '';
     SetLength(Buffer, BytesAvailable);
     BytesRead := Pipe.Read(Buffer[1], BytesAvailable);
     Result := Result + Copy(Buffer, 1, BytesRead);
@@ -8992,6 +8993,7 @@ function TDBQuery.ColumnExists(ColumnName: String): Boolean;
 
 function TDBQuery.GetColBinData(Column: Integer; var baData: TBytes): Boolean;
 begin
+  Result := False;
   Raise EDbError.Create(SNotImplemented);
 end;
 
diff --git a/source/main.pas b/source/main.pas
@@ -4335,7 +4335,7 @@ procedure TMainForm.DataGridContextPopup(Sender: TObject; MousePos: TPoint;
   HitInfo: THitInfo;
 begin
   // Prevent context popup if clicked on header, or click was not on a node
-  (Sender as TLazVirtualStringTree).GetHitTestInfoAt(MousePos.X, MousePos.Y, True, HitInfo);
+  (Sender as TLazVirtualStringTree).GetHitTestInfoAt(MousePos.X, MousePos.Y, True, {%H-}HitInfo);
   Handled := (HitInfo.HitNode = nil);
 end;
 
@@ -5281,7 +5281,7 @@ procedure TMainForm.actDataInsertExecute(Sender: TObject);
     if (Sender = actDataDuplicateRowWithoutKeys) or (Sender = actDataDuplicateRowWithKeys) then
       DupeNode := Grid.FocusedNode;
     RowNum := Results.InsertRow;
-    NewNode := Grid.InsertNode(Grid.FocusedNode, amInsertAfter, PInt64(RowNum));
+    NewNode := Grid.InsertNode(Grid.FocusedNode, amInsertAfter, {%H-}PInt64(RowNum));
     SelectNode(Grid, NewNode);
     if Assigned(DupeNode) then begin
       // Copy values from source row, ensure we have whole cell data
@@ -6686,7 +6686,7 @@ procedure TMainForm.SynCompletionProposalExecute(Sender: TObject);
   Param: TRoutineParam;
   DisplayText: String;
   SQLFunc: TSQLFunction;
-  DummyPos: Integer;
+  DummyPos: Integer=0;
 
   procedure AddTable(Obj: TDBObject);
   var
