Prefer UTF-8 encoding for loading files, instead of auto-detection, which breaks in many cases. See https://www.heidisql.com/forum.php?t=44351

ansgarbecker · ansgarbecker · commit df6abc9b2585 · 2025-08-16T15:49:23.000+02:00
diff --git a/source/loaddata.pas b/source/loaddata.pas
@@ -681,16 +681,7 @@ procedure Tloaddataform.btnOpenFileClick(Sender: TObject);
   Dialog.EncodingIndex := AppSettings.ReadInt(asFileDialogEncoding, Self.Name);
   if Dialog.Execute then begin
     editfilename.Text := Dialog.FileName;
-    FFileEncoding := Mainform.GetEncodingByName(Dialog.Encodings[Dialog.EncodingIndex]);
-    if FFileEncoding = nil then begin
-      MessageDialog(_('Auto detecting the encoding of a file is highly discouraged. You may experience data loss if the detection fails.') +
-        SLineBreak + SLineBreak +
-        _('To avoid this message select the correct encoding before pressing Open.'),
-        mtWarning, [mbOK]);
-      TestStream := TFileStream.Create(Dialog.Filename, fmOpenRead or fmShareDenyNone);
-      FFileEncoding := DetectEncoding(TestStream);
-      TestStream.Free;
-    end;
+    FFileEncoding := TEncoding.UTF8;
     grpParseMethod.OnClick(Sender);
     AppSettings.WriteInt(asFileDialogEncoding, Dialog.EncodingIndex, Self.Name);
   end;
diff --git a/source/main.pas b/source/main.pas
@@ -3948,24 +3948,13 @@ procedure TMainForm.actLoadSQLExecute(Sender: TObject);
   Dialog.Encodings.Assign(FileEncodings);
   Dialog.EncodingIndex := AppSettings.ReadInt(asFileDialogEncoding, Self.Name);
   if Dialog.Execute then begin
-    Encoding := GetEncodingByName(Dialog.Encodings[Dialog.EncodingIndex]);
-    if Encoding = nil then begin
-      ProceedResult := MessageDialog(_('Really auto-detect file encoding?') + SLineBreak + SLineBreak +
-        _('Auto detecting the encoding of a file is highly discouraged. You may experience data loss if the detection fails.') + SLineBreak + SLineBreak +
-        _('To avoid this message select the correct encoding before pressing Open.'),
-        mtConfirmation, [mbYes, mbCancel]);
-    end else begin
-      ProceedResult := mrYes;
-    end;
-
-    if ProceedResult = mrYes then begin
-      if not RunQueryFiles(Dialog.Files, Encoding, Sender=actRunSQL) then begin
-        for i:=0 to Dialog.Files.Count-1 do begin
-          Tab := GetOrCreateEmptyQueryTab(False);
-          Tab.LoadContents(Dialog.Files[i], True, Encoding);
-          if i = Dialog.Files.Count-1 then
-            SetMainTab(Tab.TabSheet);
-        end;
+    Encoding := TEncoding.UTF8;
+    if not RunQueryFiles(Dialog.Files, Encoding, Sender=actRunSQL) then begin
+      for i:=0 to Dialog.Files.Count-1 do begin
+        Tab := GetOrCreateEmptyQueryTab(False);
+        Tab.LoadContents(Dialog.Files[i], True, Encoding);
+        if i = Dialog.Files.Count-1 then
+          SetMainTab(Tab.TabSheet);
       end;
     end;
     AppSettings.WriteInt(asFileDialogEncoding, Dialog.EncodingIndex, Self.Name);
diff --git a/source/texteditor.pas b/source/texteditor.pas
@@ -418,7 +418,7 @@ procedure TfrmTextEditor.btnLoadTextClick(Sender: TObject);
   d.EncodingIndex := AppSettings.ReadInt(asFileDialogEncoding, Self.Name);
   if d.Execute then try
     Screen.Cursor := crHourglass;
-    MemoText.Text := ReadTextFile(d.FileName, MainForm.GetEncodingByName(d.Encodings[d.EncodingIndex]));
+    MemoText.Text := ReadTextFile(d.FileName, TEncoding.UTF8);
     if (FMaxLength > 0) and (Length(MemoText.Text) > FMaxLength) then
       MemoText.Text := copy(MemoText.Text, 0, FMaxLength);
     AppSettings.WriteInt(asFileDialogEncoding, d.EncodingIndex, Self.Name);
